Refactoring: Move platform specific code files to src/ #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Aug 29, 2022
pljones
approved these changes
Aug 29, 2022
|
I'd wait until the CI is green and then test the artifacts. |
pljones
approved these changes
Aug 29, 2022
|
macOS legacy build works as expected and shows the badge. I can NOT run the normal build, as something seems to be wrong with the universal build. It doesn't show up as universal but ARM now? |
|
iOS also installs and works correctly. |
|
Ok. Great. So I'll merge it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Moves the platform specific code to src/
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for testing and review.
What is missing until this pull request can be merged?
Testing.. Should either compile or not compile to show if everything is working.
Checklist