Translation: Add empty nb_NO translation files #2849
Conversation
|
We also need to add him to the org and multiple other places. |
|
This would make nb_NO show up as a selectable language despite having no translations right now, correct? |
|
@ann0see Unless it is the Weblate bot, I could add myself if there is a "Translator credit" string wherein it is possible to also write down an e-mail, so people can reach out. @hoffie nb_NO will be given by the locale if available anyway, the selection is secondary. |
|
I'm proposing 3.10.0 for this. |
Why? I think translations are non blocking and having a translation of the most important parts is better than having none. Also they should go in as soon as possible |
Yes. |
|
I'd be ok with adding everything what is necessary to make nb_NO show up for translation on Weblate, but keeping the language unlisted as long as there are no translations at all. Once there are translations, I'm fine with making it usable from within Jamulus. I'm also fine with this going into 3.9.1 depending on the timing. I guess we wouldn't delay 3.9.1 for that though. (We use Addition of translations which were too late to be included into the last release. as one acceptable type of change for patch-level releases such as 3.9.1; while this was initially meant to target the addition of translation strings of existing translated languages, I see no reason to "block" completely new translations based on that) |
|
OK, seeing as it doesn't touch source and it can't break things, I guess there's no reason to delay it. |
|
@comradekingu Could you please comment on #2758 with your suggestions about The Weblate process? Since we're quite new to it, it's probably worth getting insight from you. |
No. That's another step we need to do via git: Add yourself to util.h as translator |
| @@ -14,6 +14,9 @@ | |||
| <qresource prefix="/translations"> | |||
| <file alias="translation_es">translation/translation_es_ES.qm</file> | |||
| </qresource> | |||
| <qresource prefix="/translations"> | |||
There was a problem hiding this comment.
So we'd remove this to not let the translation show up?
There was a problem hiding this comment.
I think this would work, yes (at least that was the effect when we forgot adding it for Korean, I think?).
So, yes, either that. Or go with the PR as-is and add a reminder to the 3.9.1 checklist to remove that part again if no translations have been integrated at release candidate time.
There was a problem hiding this comment.
Or go with the PR as-is and add a reminder to the 3.9.1 checklist to remove that part again if no translations have been integrated at release candidate time
I'd go with that since I understood @comradekingu that he'll start translating right away.
|
@hoffie done. |
|
@pljones feel free to merge this. |
Short description of changes
Adds nb_NO translation to Jamulus as requested by @comradekingu
CHANGELOG: Translation: Add nb_NO App translation
Context: Fixes an issue?
Raised on weblate.
Does this change need documentation? What needs to be documented and how?
Yes. Once the translation arrives the translator needs to be added to src/util.h
Status of this Pull Request
Ready for merge
What is missing until this pull request can be merged?
/
Checklist