-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include HTML in strDirectoryTypeWT #2894
Include HTML in strDirectoryTypeWT #2894
Conversation
CHANGELOG: Internal: Include HTML in strDirectoryTypeWT to make translation easier ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good.
Translation-wise I don't think there is a good way. Either translators have to re-build the translation based on the existing fragments or we have to put effort into this to combine the fragments to a proposed ("unfinished") translation.
Usually, I'm more in favor of the latter, but in this case this sounds really error-prone, so I guess it's fine as-is.
Should be 3.10.0 though as it touches translations.
Yes... I did try moving the strings by hand and cleaning up the "vanished" ones -- but I decided it would take longer than just retranslating. Particularly as the first one hadn't been fully translated anyway, making it even harder. |
43fa30d
to
d762a2f
Compare
d762a2f
to
a88297a
Compare
@pljones this needs a rebase. |
0b650ac
to
73bcb31
Compare
73bcb31
to
a683fe7
Compare
Short description of changes
Update the "What's This?" text for the Directory Type drop down in the Server dialog to be a single string including the formatting HTML. This ensures translators have the full context when translating the string. Additionally, added an
CHANGELOG: Internal: Include HTML in strDirectoryTypeWT to make translation easier
Context: Fixes an issue?
See #2856 (comment)
Does this change need documentation? What needs to be documented and how?
No, needs translation changes.
Status of this Pull Request
Can wait till 3.10.0.
What is missing until this pull request can be merged?
Needs to be merge before translations can be done.
Checklist