Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update Oboe to v1.7.0 #3000

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jan 25, 2023

Short description of changes

Updates Oboe to v1.7.0 (a stable build not the intermediate commit)

CHANGELOG: Android: Updated Oboe to version 1.7.0

Context: Fixes an issue?

/

Does this change need documentation? What needs to be documented and how?
Probably not.

Status of this Pull Request

Ready for testing (I don't have access to an android device at the moment)

What is missing until this pull request can be merged?

Review of changes of oboe code if needed.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want (Don't have access to Android at the moment. However tested by pljones)
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

AUTOBUILD: Please build all targets

@ann0see
Copy link
Member Author

ann0see commented Jul 1, 2023

Status: Needs someone with access to Android.

@pljones
Copy link
Collaborator

pljones commented Jul 2, 2023

I'll try explaining to my phone it wants to install this.

@pljones
Copy link
Collaborator

pljones commented Jul 2, 2023

Can you rebase? The builds have expired.

@pljones
Copy link
Collaborator

pljones commented Jul 2, 2023

Screenshot_20230702-122701.png

@pljones
Copy link
Collaborator

pljones commented Jul 2, 2023

OK, the build runs (and processes audio - I get nice whistling feedback... hence muting myself in the mixer).

(The server I was connected to is about two metres from my phone... joys of WiFi... ping was bouncing all over the place.)

@pljones pljones added this to the Release 3.10.0 milestone Jul 2, 2023
@ann0see
Copy link
Member Author

ann0see commented Jul 2, 2023

The Drive link is restricted.

However, from your post I think it's ok?

@pljones
Copy link
Collaborator

pljones commented Jul 2, 2023

The Drive link is restricted.

Cut'n'paste goof...

@ann0see
Copy link
Member Author

ann0see commented Jul 9, 2023

If it works, please merge it.

@pljones pljones merged commit a2658f6 into jamulussoftware:main Jul 10, 2023
@ann0see ann0see deleted the updateOboe branch July 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants