-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install JACK via web request #3003
Conversation
GH might not be worth the hassle. Using a simple web request is easier. |
d445b84
to
49b63bc
Compare
Ok. I think this is ready for review now @henkdegroot |
get_upstream_version: | | ||
curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jack/ | | ||
grep -oP '.*/jack\.\K.*(?=\.nupkg)' | ||
get_upstream_version: GH_REPO=jackaudio/jack2-releases gh release view --json tagName --jq .tagName | sed -re 's/^v//' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoffie I think this needs some verification from your end. I copied it from the other GitHub dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting risk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just two (actually only one) minor comments but twice because of the 32 and 64 install.
Tested on Win 11 and it seems to be all right. |
No surprise here....I tested on Win 10 and working fine here as well. |
I'm tempted to say just get this merged... |
@pljones feel free to review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting all outstanding comments.
|
||
if ( !$? ) | ||
{ | ||
throw "Download of "+ $Name + " (" + $Uri + ") failed with exit code $LastExitCode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why mixed syntax of variable expansion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important, resolving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Raising an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Unresolving them for convenience.
#3012
if ( !$? ) | ||
{ | ||
throw "64bit jack installation failed with exit code $LastExitCode" | ||
throw "64bit JACK installer failed with exit code $LastExitCode" | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for else
block around the echo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important, resolving.
throw "32bit jack installation failed with exit code $LastExitCode" | ||
throw "32bit JACK installer failed with exit code $LastExitCode" | ||
} else { | ||
echo "32bit JACK installation completed successfully" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important, resolving.
get_upstream_version: | | ||
curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jack/ | | ||
grep -oP '.*/jack\.\K.*(?=\.nupkg)' | ||
get_upstream_version: GH_REPO=jackaudio/jack2-releases gh release view --json tagName --jq .tagName | sed -re 's/^v//' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting risk.
Improve updated JACK autobuild (#3003)
Short description of changes
As the choco build doesn't seem to get updated, this is an alternative approach to install JACK via cli. The download is done via
gha web request in PowerShell and the installation is done via the normal installer.CHANGELOG: Internal: The JACK build will now install directly from the JACK GitHub repository
Context: Fixes an issue?
Fixes: #2992
Does this change need documentation? What needs to be documented and how?
Don't think so.
Status of this Pull Request
Ready for review. Needs to be tested.
Moreover we might need to implement cachingTested and works.What is missing until this pull request can be merged?
Check if the automated update works (bump-dependencies)
Checklist
AUTOBUILD: Please build all targets