Remove remaining directory server mentions

[pljones]

Short description of changes

The overall goal is that:

• Directory is the Jamulus term for an application that supplies a list of Jamulus Servers on request (most often the Jamulus application running as --server --directoryaddress localhost (or -s -e 127.0.0.1)).
• Directory Address is the IP address (IPv4 only, currently), possibly including port, used to contact the Directory.
• "Directory server" is an invalid term in Jamulus vocabulary.

This removes remaining "directory server" mentions in the code base (based on grep -ni directory\ \*server src/*.*).

Apart from:

• backwards compatibility for --directoryserver command line option
• RPC doccomment

(Replaced: #2997 - this is more complete)

CHANGELOG: Server: Rename --directoryserver to --directoryaddress (and internal changes)

Context: Fixes an issue?

On going maintenance to avoid confusion in terminology.

Does this change need documentation? What needs to be documented and how?

Yes. --help output now says --directoryaddress plus a few other changes. Translations affected in places, too (I added some more server GUI ones).

Status of this Pull Request

It runs okay.

What is missing until this pull request can be merged?

• Review.
• Fixing generate_json_rpc_docs.py script (@hoffie ?)
• Fixing clang_format...

Note: the Json RPC "directory_server" mention is in its external protocol, not just a comment, so needs consideration before just changing it. The other changes here affect nothing outside Jamulus.

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[pljones]

Huh?

(Raised #3018)

And Github clang_format and Ubuntu seem to have got out of alignment on my machine again..!

[pljones]

So

"--clang-format-executable" "/clang-format/clang-format10"

$ clang-format --version
Ubuntu clang-format version 14.0.0-1ubuntu1

I guess I need to find clang-format-10 again...

[pljones]

Well, so clang-format-10 is no longer available and installing 11 made no difference locally.

$ sudo apt install clang-format<TAB><TAB>
clang-format     clang-format-11  clang-format-12  clang-format-13  clang-format-14  clang-format-15

(Raised #3019)

[ann0see]

Would --directory instead of --directoryaddress be confusing?

[pljones]

Would --directory instead of --directoryaddress be confusing?

I had --directory until this afternoon. But it's the address (in Internet Address including Port terms) of the Directory, not the Directory itself. See "The overall goal is that:" in the PR description.

[pljones]

OK, I don't think there's anything outstanding here now?

[ann0see]

See comment.

[ann0see]

I think by sight reviewing this looks ok.

[pljones]

Raised jamulussoftware/jamuluswebsite#919 for the documentation change.

[pljones]

https://github.com/jamulussoftware/jamulus/actions/runs/4713980244/jobs/8379530170 is still failing on main (but didn't on the branch, which was up to date with main...). Anyone understand why?

Raised #3049

[ann0see]

@pljones I think we can drop the needs documentation flag here too.