RPC: remove remaining directory server mentions

[pljones]

Short description of changes

CHANGELOG: RPC: Rename directoryServer to directory in jamulusserver/getServerProfile response

Context: Fixes an issue?

RPC changes separated from main change due to RPC doc issues that got resolved.

Does this change need documentation? What needs to be documented and how?

RPC doc changes in line with API change.

Status of this Pull Request

Untested as I don't use RPC.

What is missing until this pull request can be merged?

Seems trivial, so I'd just do it. I've been running builds with this change in (but without using the RPC API).

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[pljones]

@dtinth I'd also appreciate your review, but I can't add you as a reviewer for some reason.

[dtinth]

LGTM.

Btw, this is a breaking change for consumers, but since JSON-RPC is “experimental” it does not need to obey semver. Still, it may be worth mentioning in the changelog to make this change less surprising.

[pljones]

Btw, this is a breaking change for consumers, but since JSON-RPC is “experimental” it does not need to obey semver. Still, it may be worth mentioning in the changelog to make this change less surprising.

Yeah, true. Done.

[ann0see]

I think everything is documented here too? @pljones please drop needs documentation if you think it's valid to drop.

[pljones]

Mmm, the doc-gen stuff is there. We don't do jamuluswebsite doc for JSONRPC, right?

[ann0see]

We don't do jamuluswebsite doc for JSONRPC, right?

True. There's not much on the website. The actual documentation of the API is currently in the repo.

[pljones]

Unlabelled, then.