Autobuild: Harden Regex syntax for detecting Qt 5 #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
approved these changes
May 1, 2023
|
Force merging this as it is needed for the Qt6 update PR to proceed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Hardens the detection of QT 5 in macOS and iOS build scripts. This at least moves the build in #3042 a bit further
Had wrong branch on this PR: #3055
CHANGELOG: Autobuild: Hardened detection of QT 5 builds for macOS and iOS
Context: Fixes an issue?
Not yet documented. But related and discussed in #3042.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for review. This is just a partial fix.
What is missing until this pull request can be merged?
Testing in the mentioned PR. But I'll cherry-pick this commit into the PR.
Checklist