Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Opus to v1.4 #3099

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Update Opus to v1.4 #3099

merged 1 commit into from
Jul 29, 2023

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jul 10, 2023

Short description of changes

Updates Opus to the latest version. Local testing on Linux was ok.

CHANGELOG: Updated Opus to v1.4

Context: Fixes an issue?

Should fix some compiler warnings.

Fixes: #2817

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Needs testing on Windows

What is missing until this pull request can be merged?

Review and test on non Linux OS

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see
Copy link
Member Author

ann0see commented Jul 10, 2023

Just wanted to link xiph/opus#241 as this will introduce opus as submodule.

@ann0see
Copy link
Member Author

ann0see commented Jul 11, 2023

After thinking a bit more, I'm no longer sure if a submodule is the right approach as users will need to do additional work. Maybe just doing a plain git clone is better.

@ann0see
Copy link
Member Author

ann0see commented Jul 12, 2023

Ok. I've now removed the submodule and just included the repo directly via a git clone. Should be easier.

@ann0see
Copy link
Member Author

ann0see commented Jul 23, 2023

@pljones would you add this to the next release or should we wait?

@pljones
Copy link
Collaborator

pljones commented Jul 24, 2023

I'll pull the Windows assets and test it - if it's okay I think we should go ahead.

@ann0see ann0see added this to the Release 3.10.0 milestone Jul 24, 2023
@pljones
Copy link
Collaborator

pljones commented Jul 25, 2023

Opens and runs. I got one settings glitch (Qt6-related, I think) - "My Profile" tab didn't appear first time I ran. Couldn't reproduce the glitch, though.

I'll be trying it out for audio tomorrow.

Hm, could do with a rebase? Looked like Qt6.5.1.
https://github.com/jamulussoftware/jamulus/pull/3110/files

@ann0see
Copy link
Member Author

ann0see commented Jul 25, 2023

Done. I've also experienced this bug. Qt6 feels buggy.

@ann0see
Copy link
Member Author

ann0see commented Jul 28, 2023

@pljones I hope this now works.

@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

@pljones I hope this now works.

Yep, Qt6.5.2 and "My Profile" tab appears on clicking the "Settings" checkbox.

@ann0see ann0see merged commit fec172f into jamulussoftware:main Jul 29, 2023
15 checks passed
@ann0see ann0see deleted the updateOpus branch July 29, 2023 10:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

libs/opus: New warnings including some somewhat worrying
2 participants