-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Opus to v1.4 #3099
Update Opus to v1.4 #3099
Conversation
Just wanted to link xiph/opus#241 as this will introduce opus as submodule. |
After thinking a bit more, I'm no longer sure if a submodule is the right approach as users will need to do additional work. Maybe just doing a plain git clone is better. |
Ok. I've now removed the submodule and just included the repo directly via a git clone. Should be easier. |
@pljones would you add this to the next release or should we wait? |
I'll pull the Windows assets and test it - if it's okay I think we should go ahead. |
Opens and runs. I got one settings glitch (Qt6-related, I think) - "My Profile" tab didn't appear first time I ran. Couldn't reproduce the glitch, though. I'll be trying it out for audio tomorrow. Hm, could do with a rebase? Looked like Qt6.5.1. |
Done. I've also experienced this bug. Qt6 feels buggy. |
@pljones I hope this now works. |
Yep, Qt6.5.2 and "My Profile" tab appears on clicking the "Settings" checkbox. |
Short description of changes
Updates Opus to the latest version. Local testing on Linux was ok.
CHANGELOG: Updated Opus to v1.4
Context: Fixes an issue?
Should fix some compiler warnings.
Fixes: #2817
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Needs testing on Windows
What is missing until this pull request can be merged?
Review and test on non Linux OS
Checklist