-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2975 Headless _builds_ use fewer libraries #3117
Merged
pljones
merged 1 commit into
jamulussoftware:main
from
pljones:patch/omit-gui-acknowledgements-from-headless-startup-log
Sep 18, 2023
Merged
#2975 Headless _builds_ use fewer libraries #3117
pljones
merged 1 commit into
jamulussoftware:main
from
pljones:patch/omit-gui-acknowledgements-from-headless-startup-log
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
3 times, most recently
from
August 1, 2023 17:34
674f97e
to
61bbf15
Compare
pljones
changed the title
2975 Headless _builds_ use fewer libraries
#2975 Headless _builds_ use fewer libraries
Aug 1, 2023
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
from
August 3, 2023 18:34
61bbf15
to
ca03b6e
Compare
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
from
August 15, 2023 16:15
ca03b6e
to
ef6210c
Compare
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
4 times, most recently
from
August 28, 2023 12:32
ea8bac9
to
fd8fe18
Compare
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
2 times, most recently
from
September 12, 2023 16:19
8dd202e
to
e438c70
Compare
ann0see
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you tested it, and the code seems ok, approving
ann0see
reviewed
Sep 14, 2023
ann0see
reviewed
Sep 14, 2023
pljones
force-pushed
the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
from
September 16, 2023 10:34
e438c70
to
1a84370
Compare
ann0see
reviewed
Sep 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
pljones
deleted the
patch/omit-gui-acknowledgements-from-headless-startup-log
branch
September 18, 2023 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
CONFIG+="headless"
is usedCHANGELOG: Client/Server: Improved start up logging
Context: Fixes an issue?
Fixes: 2975
Does this change need documentation? What needs to be documented and how?
Possibly there are examples of start up that might change. Needs checking.
Status of this Pull Request
Tested locally:
Non-headless build:
Headless build:
The removed section reads:
What is missing until this pull request can be merged?
Checklist