Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trebmuh to create-translation-issues.sh #3147

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add trebmuh to create-translation-issues.sh #3147

merged 2 commits into from
Aug 15, 2023

Conversation

jujudusud
Copy link
Member

Short description of changes

Add @trebmuh as an app translator.

Context: Fixes an issue?

#3146

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Ready to be merged.

What is missing until this pull request can be merged?

Nothing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@jujudusud jujudusud self-assigned this Aug 12, 2023
@jujudusud jujudusud added the translation used by tools/create-translation-issues.sh label Aug 12, 2023
@jujudusud jujudusud added this to the Release 3.11.0 milestone Aug 12, 2023
@trebmuh
Copy link
Member

trebmuh commented Aug 13, 2023

Mmm, that was it, thank you.

@ann0see ann0see changed the title Update create-translation-issues.sh Add trebmuh to create-translation-issues.sh Aug 13, 2023
@jujudusud @ann0see
Typo, add Space.
c05b237 
Co-authored-by: ann0see <20726856+ann0see@users.noreply.github.com>
@jujudusud jujudusud requested a review from ann0see August 13, 2023 09:53
@pljones
Copy link
Collaborator

pljones commented Aug 13, 2023

@ann0see, can we get this in for 3.10.0 so @trebmuh is in the script as soon as possible?

@ann0see
Copy link
Member

ann0see commented Aug 13, 2023

If it is rebased or squashed, yes.

ann0see
ann0see approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but looks sensible

@trebmuh
Copy link
Member

trebmuh commented Aug 15, 2023

Thanks for that, people. Very much appreciated.

@jujudusud
Copy link
Member Author

@ann0see, can we get this in for 3.10.0 so @trebmuh is in the script as soon as possible?

If everyone is ok, it is ready to be merged.

@pljones pljones merged commit eb46add into jamulussoftware:main Aug 15, 2023
9 of 11 checks passed
@jujudusud jujudusud deleted the jujudusud-patch-1 branch August 15, 2023 16:49
@pljones pljones linked an issue Aug 17, 2023 that may be closed by this pull request
One of the french translator is not referenced by the script #3146
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pljones pljones pljones approved these changes

@ignotus666 ignotus666 ignotus666 approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

@jujudusud jujudusud

Labels
translation used by tools/create-translation-issues.sh
Projects
Tracking
Status: Done
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

One of the french translator is not referenced by the script
5 participants
@jujudusud @trebmuh @pljones @ann0see @ignotus666