Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show both build and runtime versions of Qt #3231

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

softins
Copy link
Member

@softins softins commented Feb 10, 2024

Short description of changes

Displays both the version of Qt the executable was built with, and the version currently running via the dynamic libraries. These are available from QT_VERSION_STR and qVersion() respectively.

jamulus --version now shows something like:

 *** This app uses the following libraries, resources or code snippets:
 *** 
 *** Qt cross-platform application framework 5.9.5 (build), 5.15.2 (runtime)
 *** <https://www.qt.io>

About Jamulus.. / Libraries shows the same information.

CHANGELOG: Client/Server: Display Qt versions for both build and runtime.

Context: Fixes an issue?

Fixes: #3230

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Tested and ready to merge.

What is missing until this pull request can be merged?

Just review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins requested a review from pljones February 10, 2024 18:01
src/util.cpp Show resolved Hide resolved
@softins softins changed the title Show both build and running versions of Qt Show both build and runtime versions of Qt Feb 11, 2024
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok now to me.

@softins softins merged commit 79d3284 into jamulussoftware:main Feb 12, 2024
11 checks passed
@softins softins deleted the qt-version-display branch February 12, 2024 18:03
@pljones pljones added this to the Release 3.11.0 milestone Jul 28, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

jamulus --version should show Qt version from dynamic libraries
3 participants