Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Qt6 from 6.6.1 to 6.6.3 (Automated PR) #3236

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 17, 2024

This automated Pull Request updates the used Qt6 version to version 6.6.3.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled Qt6 to version 6.6.3

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 2 times, most recently from 08b6b72 to 1fc3e6d Compare February 17, 2024 12:12
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 5 times, most recently from 237b090 to d634fa4 Compare March 4, 2024 19:14
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Qt version update only affects the main Mac build and the Windows build. I can't test the Mac one, but the Windows build seems to install and run fine, so happy to approve.

@softins softins requested a review from ann0see March 15, 2024 23:08
@softins softins requested a review from pljones March 26, 2024 16:29
@pljones
Copy link
Collaborator

pljones commented Mar 26, 2024

I've been building Linux with Qt6 for a while -- we should migrate that, too, fairly soon as it seems stable.

@pljones
Copy link
Collaborator

pljones commented Mar 26, 2024

As a general point, though, when I run MaintenanceTool on Linux, 6.6.2 isn't offered. I can see only 6.6.1 and 6.6.3, so I don't know if 6.6.2 is worth updating to?

@pljones pljones added the tooling Changes to the automated build system label Mar 26, 2024
@pljones pljones added this to the Release 3.11.0 milestone Mar 26, 2024
@softins
Copy link
Member

softins commented Mar 26, 2024

As a general point, though, when I run MaintenanceTool on Linux, 6.6.2 isn't offered. I can see only 6.6.1 and 6.6.3, so I don't know if 6.6.2 is worth updating to?

Looks like 6.6.3 was released in the last couple of days, and the tests in the Bump Dependencies workflow would now return 6.6.3 (I've tested manually). So I'll make the workflow run again, and it should replace this PR with a fresh one.

@github-actions github-actions bot changed the title Build: Bump Qt6 from 6.6.1 to 6.6.2 (Automated PR) Build: Bump Qt6 from 6.6.1 to 6.6.3 (Automated PR) Mar 26, 2024
Copy link
Author

PR has been updated for version 6.6.3 by the workflow Bump dependencies (create-prs).

@softins softins self-requested a review March 26, 2024 17:48
@softins
Copy link
Member

softins commented Mar 26, 2024

So I'll make the workflow run again, and it should replace this PR with a fresh one.

It's even cleverer: it's updated this PR. Will let the CI build and try the Windows version.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on macOS 14.4 (Intel)

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows build runs fine.

@softins softins merged commit 2f769f5 into main Mar 26, 2024
12 checks passed
@github-actions github-actions bot deleted the ci/bump-dependencies/Qt6 branch March 26, 2024 23:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to the automated build system
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants