Refactor UpdateDisplay() to call UpdateUploadRate() #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from: jamulussoftware#2550 Related to: https://github.com/jamulussoftware/jamulus/pull/3364/files/21815c1a0708979fe0414c30e0294feaa7632be3#r1759185427 Co-authored-by: ann0see <20726856+ann0see@users.noreply.github.com>
ann0see
commented
Sep 13, 2024
| @@ -1063,25 +1063,31 @@ void CClientSettingsDlg::OnSndCrdBufferDelayButtonGroupClicked ( QAbstractButton | |||
| UpdateDisplay(); | |||
| } | |||
|
|
|||
| /// @method | |||
There was a problem hiding this comment.
Probably no need to add @ method here.
5 tasks
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Sep 13, 2024
Factored out into jamulussoftware#3369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Refactor UpdateDispay() method. This was extracted from #2550
and is related to: https://github.com/jamulussoftware/jamulus/pull/3364/files/21815c1a0708979fe0414c30e0294feaa7632be3#r1759185427
It makes sense to call UpdateUploadRate() from UpdateDisplay() since it gets same functionality to the same place.
Not sure, if the condition is correct, as we do not check if pClient is running, but rather it is connected now.
CHANGELOG: SKIP
Context: Fixes an issue?
No.
Does this change need documentation? What needs to be documented and how?
No. This even adds documentation
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review. Tested locally by disconnecting and connecting via GUI and changing Audio quality and enabling/disabling small network buffers. Network rate shows correctly. Also checked by starting Jamulus with
-cflag and seems to do what it should do: Label shows correct data if connected and---if not connected.Checklist