Sharing resource initiated by the app #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: elf Pavlik <elf-pavlik@hackers4peace.net>
Co-authored-by: elf Pavlik <elf-pavlik@hackers4peace.net>
Co-authored-by: elf Pavlik <elf-pavlik@hackers4peace.net>
…multiple agents Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
angelaraya
suggested changes
Apr 12, 2023
There was a problem hiding this comment.
Overall there are some changes that are needed, mostly around minimizing function complexity on large functions. Also I'd like to see more documentation on what/why/where things are needed, even just linking to the relevant parts of the spec would come a long way.
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
Co-authored-by: Maciej Samoraj <samurex@users.noreply.github.com>
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes one main feature for the next release: sharing resources initiated from the application.
It also includes updates to all dependencies and fixed linting errors.
closes #42
closes #50