-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressed trace files #154
Labels
Milestone
Comments
cgaebel
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Apr 15, 2022
@Lilydemi has a PR for this! |
bnigito
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…rfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org>
bnigito
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…rfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org>
bnigito
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…rfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org>
bnigito
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…rfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org>
Xyene
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…erfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org> Co-authored-by: Tudor Brindus <tbrindus@janestreet.com>
Xyene
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 4, 2024
…erfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org> Co-authored-by: Tudor Brindus <tbrindus@janestreet.com>
Xyene
added a commit
that referenced
this issue
Oct 4, 2024
…erfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes #154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org> Co-authored-by: Tudor Brindus <tbrindus@janestreet.com>
bnigito
added a commit
to bnigito/magic-trace
that referenced
this issue
Oct 15, 2024
…rfetto) or zstd (not yet supported) This builds on previous work for compressed file destinations Closes janestreet#154 Signed-off-by: Brian Nigito <bnigito@janestreet.com> Co-authored-by: Lidya Demilew <si.demilew@gmail.com> Co-authored-by: Hao Lian <hi@haolian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Trace files are big and compress really well, 5x-ish in my experience. Could magic-trace write out compressed traces instead of raw traces?
Perfetto already has support for loading gzipped traces. But gzip is really slow (fingers crossed for Sapphire Rapids, but that's years from being commonplace).
As far as I can tell, we have two options here:
zstd
'd traces, and also teach perfetto to load them.The first option is easier, but the second option would be faster to save and load. FWIW, Tudor thinks zstd is overkill because we're so slow at decoding otherwise.
The text was updated successfully, but these errors were encountered: