-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demangle OCaml symbols #250
Merged
Xyene
merged 1 commit into
janestreet:master
from
jane-street-immersion-program:demangle-ocaml-symbols
Jul 27, 2022
Merged
Demangle OCaml symbols #250
Xyene
merged 1 commit into
janestreet:master
from
jane-street-immersion-program:demangle-ocaml-symbols
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
July 20, 2022 15:30
7a0811a
to
510f505
Compare
seliopou
reviewed
Jul 20, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
July 20, 2022 19:34
510f505
to
c6c4718
Compare
Thank you for the comments! I resolved them. I appreciate it. |
@seliopou ready for review if you have free time! |
hlian
reviewed
Jul 22, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
2 times, most recently
from
July 25, 2022 19:18
3a5ba05
to
a75cfdb
Compare
Xyene
reviewed
Jul 25, 2022
Xyene
reviewed
Jul 25, 2022
Xyene
reviewed
Jul 25, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
July 25, 2022 19:47
a75cfdb
to
8f27985
Compare
Could you please rebase to pick up ad91ae0, so we can kick off CI again? |
Signed-off-by: Clyve Gassant <cgassant@sas.upenn.edu>
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
July 27, 2022 14:55
8f27985
to
a81352a
Compare
@Xyene I completed your comment! |
Xyene
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #82 by implementing the demangling parser from perf. I also included expect tests.