Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertf and use in boot.janet. Address #1516 #1517

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Oct 30, 2024

This is an attempt to address #1516 by adding assertf (borrowed from @ianthehenry) to boot.janet.

The PR also includes attempts to apply assertf within boot.janet. I've used %v in some places but I'm not sure if that was appropriate.

Also, there was one bit of code that used errorf (may be as a short-cut?):

(assert bundle-name (errorf "unable to infer bundle name for %v, use :name argument" path))

this was replaced with:

(assertf bundle-name "unable to infer bundle name for %v, use :name argument" path)

I hope that was appropriate (^^;

For background, please see the Zulip discussion and the corresponding issue.

@pepe
Copy link
Member

pepe commented Oct 30, 2024

It looks fine, do you plan to add tests for it?

@sogaiu
Copy link
Contributor Author

sogaiu commented Oct 30, 2024

I totally didn't think of it (^^;

Thanks for the reminder.

Added some things. Not sure how appropriate they are. How do they look?

@pepe
Copy link
Member

pepe commented Oct 30, 2024

LGTM

@bakpakin bakpakin merged commit e52575e into janet-lang:master Oct 31, 2024
12 of 13 checks passed
@sogaiu
Copy link
Contributor Author

sogaiu commented Oct 31, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants