Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define symbol early enough for use in math #204

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Nov 25, 2024

There was a CI error related to #203.

My current guess is that due to recent changes in hashing in janet, the order in which the key-value pairs are evaluated has changed.

So before may be:

spork/spork/math.janet

Lines 360 to 363 in 44e2601

{:m (def m
(/ (- (* cl sxy) (* sx sy))
(- (* cl sxx) (* sx sx))))
:b (- (/ sy cl) (/ (* m sx) cl))})))

worked fine because luckily the (def m ...) happened before the use of m for the value associated with :b.

This PR just moves the def form out of the struct.

@sogaiu
Copy link
Contributor Author

sogaiu commented Nov 25, 2024

I'm not entirely clear on why CI is failing.

FWIW, locally (also a Linux environment), the PR content appears to work fine, i.e. jpm test and janet bundle/test.janet lead to no errors.

As an additional data point, I get what looks similar to the CI error output if I do janet bundle/test.janet for 1bed0c9.

@bakpakin bakpakin merged commit 15ebaae into janet-lang:master Nov 25, 2024
6 of 13 checks passed
@bakpakin
Copy link
Member

The CI error almost looks as though it testing the wrong version of spork. Looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants