We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The library is inconsistent between 0.17.2 and 0.18.0 versions:
Test case:
import nimSHA2 var a: SHA256Digest a[0] = 'a' a[1] = 'b' a[10] = 'c' echo system.`$`(a) echo nimsha2.`$`(a) echo $a echo a.len
O.17.2
ab ab ab 32
0.18.0
['a', 'b', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', 'c', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00', '\x00'] abc abc 32
I suspect there are at least 2 reasons for this:
$
Recommandation: To avoid the $ issue it might be needed to wrap the digest array in an object like what is done in keccak_tiny
The text was updated successfully, but these errors were encountered:
Fix: 0.18.0 $ on array broke nimSHA2
b5a4d72
jangko/nimSHA2#2
Any updates on this?
Sorry, something went wrong.
No branches or pull requests
The library is inconsistent between 0.17.2 and 0.18.0 versions:
Test case:
O.17.2
0.18.0
I suspect there are at least 2 reasons for this:
$
operator on arrays$
in 0.17.2 was not iterating for the full length, stopping at the first 0 and this was fixed.Recommandation: To avoid the
$
issue it might be needed to wrap the digest array in an object like what is done in keccak_tinyThe text was updated successfully, but these errors were encountered: