Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible change the color of bullet? #37

Closed
Spiderbezno opened this issue Apr 6, 2016 · 13 comments
Closed

Is it possible change the color of bullet? #37

Spiderbezno opened this issue Apr 6, 2016 · 13 comments
Assignees
Milestone

Comments

@Spiderbezno
Copy link

Spiderbezno commented Apr 6, 2016

Is it possible change the color of bullet?

@daniel-stoneuk
Copy link
Collaborator

What do you mean by "the bullet"?

@janheinrichmerker
Copy link
Owner

Do you mean the pager indicator dots?

@Spiderbezno
Copy link
Author

Yes the page indicator

@janheinrichmerker
Copy link
Owner

That could be an option...
Another option would be to have the grey dots always the color of the status bar and changing the white dots to grey similar to the way the status bar switches between light mode/dark mode based on the luminance of the background.
I kinda think that's the better way as it would be easier for devs implementing material-intro to rely on readability without having to deal with foreground colors at all

@janheinrichmerker
Copy link
Owner

Indicator colors are automatically set dependent on what background color you set to ensure maximum contrast.

@Spiderbezno
Copy link
Author

And this change will appear in the version 1.4??

@janheinrichmerker
Copy link
Owner

Yes, but you can already use the feature now by using this dependency: https://jitpack.io/#com.heinrichreimersoftware/material-intro/-1.3-gae3e9e8-4

@Spiderbezno
Copy link
Author

OK thx

@Spiderbezno
Copy link
Author

Spiderbezno commented May 2, 2016

I tried, and the major part change color correctly, but the point selected(color white) in a background white-grey is not visible. In my case this "problem", it's only aesthetic and the global result is nice.
screenshot_20160502-133113

@janheinrichmerker
Copy link
Owner

You need to define another backgroundDark. E.g. try #E0E0E0 and it should look better.

@Spiderbezno
Copy link
Author

Background dark in my style?
You need to define another backgroundDark. E.g. try #E0E0E0 and it should look better.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#37 (comment)

@janheinrichmerker
Copy link
Owner

Yes use brighter shade of grey instead of black

@Spiderbezno
Copy link
Author

THX, now is perfect
screenshot_20160503-085714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants