-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to avoid collision with app using lib #180
Add prefix to avoid collision with app using lib #180
Conversation
I renamed all resources. If that's too much just tell me and I'll just rename frags and layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested code auto completion for the attributes?
So if you type in a style attribute in a ParallaxLayout using Android Studio's Editor does it show a list with the available attributes from the library?
If not I think it may be safer to not rename styleable attributes.
The rest is perfect! Thank you for the PR!
On a side note: do you agree that the code will be published under the MIT license? I'm currently switching out the Apache license for the more permissive MIT license as you can read in #176 |
Ah and I don't think adding a prefix to the themes would be necessary as they are already prefixed |
Oh, I meant in the layout editor when you edit the layout XML. Sorry, I must've made this more clear. |
OK, I'll check that and amend if needed. |
I had some problems getting autocomplete to work with both the new and old. So I cannot prove my change works -> revert changes for the attributes. |
I did not fix Theme name in themes.xml. Perhaps that should be renamed also...