Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to avoid collision with app using lib #180

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

odin-
Copy link
Contributor

@odin- odin- commented Mar 8, 2017

I did not fix Theme name in themes.xml. Perhaps that should be renamed also...

@odin-
Copy link
Contributor Author

odin- commented Mar 8, 2017

I renamed all resources. If that's too much just tell me and I'll just rename frags and layout.

Copy link
Owner

@janheinrichmerker janheinrichmerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested code auto completion for the attributes?
So if you type in a style attribute in a ParallaxLayout using Android Studio's Editor does it show a list with the available attributes from the library?
If not I think it may be safer to not rename styleable attributes.
The rest is perfect! Thank you for the PR!

@janheinrichmerker
Copy link
Owner

On a side note: do you agree that the code will be published under the MIT license? I'm currently switching out the Apache license for the more permissive MIT license as you can read in #176

@janheinrichmerker
Copy link
Owner

Ah and I don't think adding a prefix to the themes would be necessary as they are already prefixed Theme.Intro. and more importantly they are part of the public API so we can't change that without depreciating the old name slowly.

@odin-
Copy link
Contributor Author

odin- commented Mar 8, 2017

Seems to work (attaching picture).
autocompletion

MIT sounds like the saner choice. I am all in :-)

@janheinrichmerker
Copy link
Owner

Oh, I meant in the layout editor when you edit the layout XML. Sorry, I must've made this more clear.

@odin-
Copy link
Contributor Author

odin- commented Mar 8, 2017

OK, I'll check that and amend if needed.

@odin- odin- force-pushed the feat_add_prefix branch from ed4ca3f to cff80c1 Compare March 8, 2017 22:47
@odin-
Copy link
Contributor Author

odin- commented Mar 8, 2017

I had some problems getting autocomplete to work with both the new and old. So I cannot prove my change works -> revert changes for the attributes.

@janheinrichmerker janheinrichmerker merged commit 28ddd56 into janheinrichmerker:master Mar 8, 2017
@odin- odin- deleted the feat_add_prefix branch March 9, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants