Improvements #29
Closed
Improvements #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test if Views are available (to prevent Exceptions in custom layouts), improve permission update handling, temporarily fix after-rotation lock bug.
|
Why didn't you merge this PR? |
|
The conditional allocation doesn't improve code readability. And in terms of performance there won't be any measurable difference between this and the if-else-statement. |
|
The error handling is already part of the latest code. |
|
Oh, I didn't see that. Still, you should take a look at the way I handle background luminance specific text color, that part is pretty duplicated. The new error handling is better than mine for code readability, of course. |
|
Thanks! The code now is a lot cleaner :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if Views are available (to prevent Exceptions in custom layouts), improve permission update handling, temporarily fix after-rotation lock bug #20 (I hope).