Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: attempt to release running services on exit #927

Merged
merged 2 commits into from
Jul 26, 2024
Merged

chore: attempt to release running services on exit #927

merged 2 commits into from
Jul 26, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 26, 2024 •
edited
Loading

Describe Your Changes

  • Cortex CPP service still running even when application exit
  • Install cuda toolkit dependencies on tensorrt-llm engine init

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan merged commit e0746e7 into dev Jul 26, 2024
2 checks passed
@louis-jan louis-jan deleted the chore/attempt-to-suspend-cortex-services branch July 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-jan @namchuai @marknguyen1302