fix: validate context length (#2871)

* fix: adjust context_length min and conditional for remote model * fix: remove console
janhq · May 6, 2024 · 9effb6a · 9effb6a
1 parent 1e3e5a8
commit 9effb6a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/web/screens/Chat/ModelSetting/SettingComponent.tsx b/web/screens/Chat/ModelSetting/SettingComponent.tsx
@@ -3,6 +3,7 @@ import {
   InputComponentProps,
   CheckboxComponentProps,
   SliderComponentProps,
+  InferenceEngine,
 } from '@janhq/core'
 
 import { useAtomValue } from 'jotai/react'
@@ -37,7 +38,9 @@ const SettingComponent: React.FC<Props> = ({
             description={data.description}
             min={min}
             max={
-              data.key === 'max_tokens'
+              data.key === 'max_tokens' &&
+              activeThread &&
+              activeThread.assistants[0].model.engine === InferenceEngine.nitro
                 ? Number(
                     activeThread &&
                       activeThread.assistants[0].model.settings.ctx_len

diff --git a/web/screens/Chat/ModelSetting/predefinedComponent.ts b/web/screens/Chat/ModelSetting/predefinedComponent.ts
@@ -33,7 +33,7 @@ export const presetConfiguration: Record<string, SettingComponentProps> = {
       'The context length for model operations varies; the maximum depends on the specific model used.',
     controllerType: 'slider',
     controllerProps: {
-      min: 0,
+      min: 128,
       max: 4096,
       step: 128,
       value: 2048,