Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce inference tools #2493

Merged

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Mar 25, 2024

Describe Your Changes

  • Extensions/assistants can now register the Inference Tool to be used across extensions/apps, which was not available previously. This eliminates the need for a hacky retrieval tool implementation (modifying & proxying requests), which added a lot of messy logic and code.
graph TD;
    AssistantExtension --> |registers Tools| CoreSDK;
    App --> |imports| CoreSDK;
    Extension --> |imports| CoreSDK;
    CoreSDK --> |uses| Tools;
    Tools --> |inference|Engines
Loading

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Mar 25, 2024
@louis-jan louis-jan mentioned this pull request Mar 25, 2024
28 tasks
@louis-jan louis-jan force-pushed the feat/introduce-assistant-tools branch from 861fce5 to 1f3ebdb Compare March 25, 2024 16:15
@louis-jan louis-jan force-pushed the feat/introduce-assistant-tools branch from 1f3ebdb to 1c56101 Compare March 25, 2024 16:22
@louis-jan louis-jan merged commit 8e8dfd4 into chore/load-unload-model-sync Mar 25, 2024
@louis-jan louis-jan deleted the feat/introduce-assistant-tools branch March 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, integration, packaging related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants