Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing load model error message #2581

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

Since the app will not attempt to send a message when the model fails to start, there is no error message sent back to the app. I have decoupled the error message into two smaller components to handle both cases. It's also to address the wrong toast icon.

Screenshot 2024-04-02 at 20 45 31

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Apr 2, 2024
@louis-jan louis-jan requested a review from Inchoker April 2, 2024 14:13
@louis-jan louis-jan merged commit 6f0ee23 into dev Apr 2, 2024
6 checks passed
@louis-jan louis-jan deleted the fix/missing-load-model-error branch April 2, 2024 15:16
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants