Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/deprecate hugging face ext #2620

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Refactor/deprecate hugging face ext #2620

merged 8 commits into from
Apr 16, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Apr 4, 2024 •
edited
Loading

Describe Your Changes

  • Allow user to download models from HuggingFace.

Screenshots

Screenshot 2024-04-09 at 14 59 44

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch 5 times, most recently from ff391b2 to 99eb14b Compare April 9, 2024 16:52
@namchuai namchuai marked this pull request as ready for review April 9, 2024 16:52
@namchuai namchuai requested a review from louis-jan April 9, 2024 16:52
@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch 5 times, most recently from 05c0340 to 850933b Compare April 11, 2024 10:58
@Van-QA
Copy link
Contributor

Van-QA commented Apr 12, 2024

related to #1740

@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch from 850933b to 971d8aa Compare April 12, 2024 09:11
@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch 3 times, most recently from 1b67fe4 to ccb6ff5 Compare April 15, 2024 07:16
James added 6 commits April 16, 2024 09:35
refactor: deprecate huggingface extension
0fecd0a
fix: update model url
53e73e9 
Signed-off-by: James <james@jan.ai>
fix: display use button for downloaded model
4240d36 
Signed-off-by: James <james@jan.ai>
fix: overflow of tags in model hub item
b1dd24b 
Signed-off-by: James <james@jan.ai>
fix: update loading indicator
41d5c82 
Signed-off-by: James <james@jan.ai>
fix: allow user to search hf and local
22a25cf 
Signed-off-by: James <james@jan.ai>
@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch 2 times, most recently from 7fd2ef9 to 5d75848 Compare April 16, 2024 03:19
@namchuai namchuai force-pushed the refactor/deprecate-hugging-face-ext branch from 5d75848 to 27a15c8 Compare April 16, 2024 04:19
@louis-jan
Copy link
Contributor

louis-jan commented Apr 16, 2024 •
edited
Loading

Resize the search box so that it hugs the content.

Screenshot 2024-04-16 at 15 02 33

Clearer message

Screenshot 2024-04-16 at 15 05 08

Do not persist embedding settings.
Screenshot 2024-04-16 at 15 12 24

Weird space
Screenshot 2024-04-16 at 15 15 48

Default Frequency Penalty = 0.7

fix comment
0b49d6a 
Signed-off-by: James <james@jan.ai>
louis-jan
louis-jan approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 31397de into dev Apr 16, 2024
7 checks passed
@namchuai namchuai deleted the refactor/deprecate-hugging-face-ext branch April 16, 2024 10:23
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @Van-QA @louis-jan