Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle enter key in cjk input method #2657

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

zhhanging
Copy link
Contributor

Describe Your Changes

  • Add checking isComposing when handling the keyboard event in submitting a message.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@zhhanging zhhanging force-pushed the feat/handle-cjk-input-enter-key branch from f7c31de to e5373ec Compare April 9, 2024 05:53
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 5a9c63a into janhq:dev Apr 9, 2024
7 checks passed
@Van-QA Van-QA added this to the v0.4.11 milestone Apr 9, 2024
@louis-jan
Copy link
Contributor

Thank you for the fix @zhhanging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Better support for Japanese/ Chinese keyboard
3 participants