chore: Extension should have product name in manifest #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
approved these changes
Apr 11, 2024
louis-jan
force-pushed
the
fix/extension-should-have-display-name-in-manifest
branch
from
ee1975f
to
dd2763f
Compare
louis-jan
deleted the
fix/extension-should-have-display-name-in-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Extensions did not have their own display names before, so we struggled with displaying their names on the Settings Page. We formatted their IDs to be presentation names, which is not correct.
Furthermore, the package name, which is actually an ID, defined in
package.jsonshould not be optional. Which could lead to many unknown errors.Typo fix
Fixes Issues
Self Checklist