Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log is not generated after clear log from setting #2732

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: log is not generated after clear log from setting #2732

merged 1 commit into from
Apr 15, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Log directory is removed, which make log writing not possible.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

fix: log is not generated after clear log from setting
b0022b9 
Signed-off-by: James <james@jan.ai>
@namchuai namchuai requested a review from louis-jan April 15, 2024 15:13
@github-actions github-actions bot added the type: bug Something isn't working label Apr 15, 2024
louis-jan
louis-jan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 889d374 into dev Apr 15, 2024
9 checks passed
@Van-QA Van-QA deleted the fix/2730 branch April 15, 2024 15:53
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @louis-jan @Van-QA