Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: detailed message when fetch invalid url #2780

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore: detailed message when fetch invalid url #2780

merged 1 commit into from
Apr 22, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Detailed message when input invalid url.

Screenshot

Screenshot 2024-04-22 at 21 21 48

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: chore Maintenance, operational label Apr 22, 2024
@Van-QA Van-QA requested a review from louis-jan April 22, 2024 14:41
Van-QA
Van-QA approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 97c15e6 into dev Apr 22, 2024
9 checks passed
@Van-QA Van-QA deleted the chore/detailed-error-when-invalid-url branch April 22, 2024 14:42
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

@urmauur urmauur urmauur approved these changes

@louis-jan louis-jan Awaiting requested review from louis-jan

Assignees

@namchuai namchuai

Labels
type: chore Maintenance, operational
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @urmauur @Van-QA