Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deeplink support #2883

Merged
merged 2 commits into from
May 13, 2024
Merged

feat: add deeplink support #2883

merged 2 commits into from
May 13, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented May 9, 2024

Describe Your Changes

  • Add deeplink support

Videos

Screen.Recording.2024-05-09.at.14.59.53.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@Van-QA
Copy link
Contributor

Van-QA commented May 9, 2024

Related to #2876.
We might need an animation in Jan app, that the popup is loading.
Just a suggestion, can we reuse this? (confirmed with Ashley 🙏)
Using this msg:
Loading model...

image

@namchuai namchuai marked this pull request as ready for review May 10, 2024 02:29
@Van-QA Van-QA merged commit 6af4a2d into dev May 13, 2024
7 checks passed
@Van-QA Van-QA deleted the feat/deep-link branch May 13, 2024 02:37
@github-actions github-actions bot added this to the v0.4.13 Broken Rice milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants