Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deeplink when app not open on linux #2893

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: deeplink when app not open on linux #2893

merged 1 commit into from
May 13, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented May 13, 2024 •
edited
Loading

Describe Your Changes

  • Fix deep link for linux user

Example

Deeplink: jan://models/huggingface/TheBloke/Magicoder-S-DS-6.7B-GGUF

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from Van-QA and louis-jan May 13, 2024 04:25
@github-actions github-actions bot added the type: bug Something isn't working label May 13, 2024
@namchuai namchuai force-pushed the fix/deep-link-linux branch 2 times, most recently from fd4cd6a to 6b4cdcc Compare May 13, 2024 06:00
@Van-QA
Copy link
Contributor

Van-QA commented May 13, 2024

#2876

Van-QA
Van-QA approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

louis-jan
louis-jan approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 08d15e5 into dev May 13, 2024
7 checks passed
@Van-QA Van-QA deleted the fix/deep-link-linux branch May 13, 2024 09:47
@github-actions github-actions bot added this to the v0.4.13 Broken Rice milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Van-QA approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @Van-QA @louis-jan