-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unchange title and last message when clean or delete message #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Van-QA
force-pushed
the
fix/unchanged-title-thread
branch
from
May 24, 2024 15:23
bde9355
to
5057eea
Compare
louis-jan
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
namchuai
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Van-QA
added a commit
that referenced
this pull request
May 27, 2024
* Fix: Phi-3 doesn't display (#2928) * fix: params correction * add phi * version bump * Feat/oai endpoints mapper using JSON (#2929) * feat: test mapper * chore: temporally add other runner * chore: temp remove ubuntu-18-04-openai-api-collection-test * chore: test json file * chore: test json file * Correct path endpoints_mapping.json * feat: running via endpoints * feat: running multiple endpoint * feat: use endpoint value from workflow dispatch * feat: add mapper between endpoint and python test file * feat: config run all * feat: config run all --------- Co-authored-by: Van-QA <van@jan.ai> Co-authored-by: Hien To <tominhhien97@gmail.com> * fix: fix crash when model name not ready (#2931) Signed-off-by: James <james@jan.ai> Co-authored-by: James <james@jan.ai> * Replace deprecated steps github action (#2935) Co-authored-by: Hien To <tominhhien97@gmail.com> * Chore: phi3 long-context update (#2936) * init * init * fix: correct version * version bump * correct url * remove small * correct size * Bump cortex to 0.4.8 (#2938) * Update README.md (#2927) Updated: Title: Turn your computer into an AI computer Nvidia -> NVIDIA M1/M2 -> M1/M2/M3/M4 * docs: Update README.md (#2939) * Bump cortex to 0.4.9 (#2940) * Code sign retry 3 times (#2943) * Replace deprecated steps github action * Windows codesign retry 3 times --------- Co-authored-by: Hien To <tominhhien97@gmail.com> * Chore: aya update (#2941) * init * init * fix: correct format * version bump * add: aya 8b, aya 35b, phi3 * fix: stop token * fix: stop token * fix: unchange title and last message when clean or delete message (#2937) * Update package.json to use next@14.2.3 (#2949) --------- Signed-off-by: James <james@jan.ai> Co-authored-by: Hoang Ha <64120343+hahuyhoang411@users.noreply.github.com> Co-authored-by: Van-QA <van@jan.ai> Co-authored-by: Hien To <tominhhien97@gmail.com> Co-authored-by: NamH <NamNh0122@gmail.com> Co-authored-by: James <james@jan.ai> Co-authored-by: hiento09 <136591877+hiento09@users.noreply.github.com> Co-authored-by: eckartal <159995642+eckartal@users.noreply.github.com> Co-authored-by: Mohammed Aldakhil <41828058+Marco-9456@users.noreply.github.com> Co-authored-by: Faisal Amir <urmauur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Screen.Recording.2024-05-22.at.17.46.37.mov
Fixes Issues
Self Checklist