Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration should not skip symlink models #3226

Merged

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 1, 2024

Describe Your Changes

Fixed migration issues where:

  • Remote models are not being migrated
  • Symlink models are not being migrated
  • Migration fail due to:
    • Missing /models
    • Models folder contains weird files
    • Model folder contains weird file
    • Messages folder does not contains messages.jsonl
Screenshot 2024-08-01 at 12 44 58 Screenshot 2024-08-01 at 12 49 52

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan changed the base branch from dev to fix/update-new-api August 1, 2024 05:49
@louis-jan louis-jan changed the title Chore/migration should not skip symlink models fix: migration should not skip symlink models Aug 1, 2024
@louis-jan louis-jan force-pushed the chore/migration-should-not-skip-symlink-models branch from 39f2f97 to 92825de Compare August 1, 2024 06:30
@Van-QA Van-QA merged commit 3d3f26e into fix/update-new-api Aug 1, 2024
@Van-QA Van-QA deleted the chore/migration-should-not-skip-symlink-models branch August 1, 2024 06:50
Van-QA added a commit that referenced this pull request Aug 2, 2024
* fix: update new api from cortex to support 0.5.0

Signed-off-by: James <namnh0122@gmail.com>

* fix stop button for streaming

Signed-off-by: James <namnh0122@gmail.com>

* fix stop inference for nonstreaming

Signed-off-by: James <namnh0122@gmail.com>

* chore: remove umami prevent tracking call to vercel

Signed-off-by: James <namnh0122@gmail.com>

* add warning modal when running more than 2 model concurrently

Signed-off-by: James <namnh0122@gmail.com>

* fix: skip summarize if abort

Signed-off-by: James <namnh0122@gmail.com>

* 0.5.0-3

* add inference error popup

Signed-off-by: James <namnh0122@gmail.com>

* add back import local model

Signed-off-by: James <namnh0122@gmail.com>

* fix: max token issue (#3225)

Signed-off-by: James <namnh0122@gmail.com>

* format status

Signed-off-by: James <namnh0122@gmail.com>

* fix migration missing instructions

Signed-off-by: James <namnh0122@gmail.com>

* fix: wait for cortex process overlay should be on top (#3224)

* fix: wait for cortex process overlay should be on top

* chore: update cortex.js

* Cortex 0.5.0-5

* add import model to my model screen

Signed-off-by: James <namnh0122@gmail.com>

* fix: should migrate symlink models (#3226)

* fix import on windows (#3229)

Signed-off-by: James <namnh0122@gmail.com>

* fix yarn lint

Signed-off-by: James <namnh0122@gmail.com>

* fix: clean up port before start jan (#3232)

Signed-off-by: James <namnh0122@gmail.com>

---------

Signed-off-by: James <namnh0122@gmail.com>
Co-authored-by: Van Pham <64197333+Van-QA@users.noreply.github.com>
Co-authored-by: Louis <louis@jan.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants