Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up console modal component #3395

Merged
merged 2 commits into from
Aug 19, 2024
Merged

chore: clean up console modal component #3395

merged 2 commits into from
Aug 19, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Aug 17, 2024

Describe Your Changes

Before
Screenshot 2024-08-17 at 22 52 15

After
Screenshot 2024-08-17 at 22 55 25

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: chore Maintenance, operational label Aug 17, 2024
@urmauur urmauur added this to the v.0.6.0 milestone Aug 17, 2024
@urmauur urmauur self-assigned this Aug 17, 2024
louis-jan
louis-jan approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 8b51d7f into dev Aug 19, 2024
9 checks passed
@urmauur urmauur deleted the chore/clean-up-console-modal-component branch August 19, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees

@urmauur urmauur

Labels
type: chore Maintenance, operational
Projects
Jan & Cortex
Archived in project
Milestone
v.0.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan