Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add toaster warning when blocked create new thread #3433

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: add toaster warning when blocked create new thread #3433

merged 1 commit into from
Aug 22, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Aug 22, 2024

Describe Your Changes

@Van-QA have good feedback here, instead return null we just return toast instead when user blocked create new thread bc there empty last message

Screenshot 2024-08-22 at 10 37 30

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Aug 22, 2024
@urmauur urmauur added this to the v.0.6.0 milestone Aug 22, 2024
@urmauur urmauur self-assigned this Aug 22, 2024
@Van-QA Van-QA merged commit 77fd172 into dev Aug 22, 2024
9 checks passed
@Van-QA Van-QA deleted the fix/create-new-thread branch August 22, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
v.0.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@urmauur @louis-jan @Van-QA