Retrieve omniauth_identity automatically when accessed for first time
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I often forget to call `retrieve_omniauth_identity` before trying to access the `omniauth_identity` attribute in `before_omniauth_callback_route`. I think we can make it automatically retrieve `omniauth_identity` the first time it's called. I haven't removed the `retrieve_omniauth_identity` method since it might already be called by users.
|
This looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often forget to call
retrieve_omniauth_identitybefore trying to access theomniauth_identityattribute inbefore_omniauth_callback_route.I think we can make it automatically retrieve
omniauth_identitythe first time it's called.I haven't removed the
retrieve_omniauth_identitymethod since it might already be called by users.