Simplify and improve the error
argument of Rephraser
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
error
argument is of typeUnion[None, str, ErrorRephraser]
.ErrorRephraser
was redefined (breaking change) from:to:
This was possible without making it less powerful by enriching
ConstraintViolated
, which now takes all three arguments thatErrorRephraser
took separately:ctx, constraint
andparams
. (breaking change)This also means that an
ErrorRephraser
can now easily reuse the original error, which is useful if all you want is to add extra info before or after the original error! Example:The original message is also available as format string field
{error}
. So the following is equivalent to the above code: