Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goroutine leak detector to tests #11

Closed
wants to merge 1 commit into from

Conversation

miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Feb 17, 2024

this is purely a safety measure. if these leak detectors fail it could mean a real leak in the code or either a badly designed test that doesn't wait till all goroutines finish before it ends.

i am not sure how to not pollute the main go.mod with this dev- only dependency.

@janos
Copy link
Owner

janos commented Feb 18, 2024

Thanks for this check, but I would also like to avoid the dependency. Since currently there are no goroutine leaks, this is a good validation, but does not have to be part of the code since the codebase is pretty stable.

@janos janos closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants