Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Not) Exclude tests from source distribution, and drop python2 tag for wheel #202

Merged
merged 6 commits into from
Sep 20, 2024
Merged

(Not) Exclude tests from source distribution, and drop python2 tag for wheel #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b805c74
exclude tests from sdist
DanielYang59 Sep 19, 2024
0c930f0
remove universal tag
DanielYang59 Sep 19, 2024
55bf3b4
remove MANIFEST.in, tests would now be included
DanielYang59 Sep 20, 2024
e6bba70
Fix RDF SVG asset paths in readme (#204)
DanielYang59 Sep 20, 2024
af87d5d
Merge branch 'main' into exclude-tests-from-pkg
janosh Sep 20, 2024
ca83032
shorten [tool.setuptools.packages.find]
janosh Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,12 @@ df-pdf-export = ["pdfCropMargins>=2", "weasyprint>=60"]
df-svg-export = ["bs4>=0.0.2", "cssutils>=2.9", "lxml>=4.9"]
auto-text-pos = ["adjustText>=0.8"]

[tool.setuptools.packages]
find = { include = ["pymatviz*"], exclude = ["tests*"] }
[tool.setuptools.packages.find]
include = ["pymatviz*"]

[tool.setuptools.package-data]
pymatviz = ["*.csv"]

[tool.distutils.bdist_wheel]
universal = true
Copy link
Collaborator Author

@DanielYang59 DanielYang59 Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag might have been misused here:

If your project also supports Python 2 and contains no C extensions, then you should create what’s called a Universal Wheel by adding the following to your setup.cfg file:
[bdist_wheel]
universal=1

For our pure python code:

The wheel package will detect that the code is pure Python, and build a wheel that’s named such that it’s usable on any Python 3 installation. For details on the naming of wheel files, see PEP 425.

Now:

python3 -m build --wheel
>>> Successfully built pymatviz-0.11.0-py3-none-any.whl

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know! thanks for troubleshooting. 👍

i have that line in a bunch of my projects. sounds like i should remove it everywhere. could you remove it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it has already been removed :)


[build-system]
requires = ["setuptools>=71"]
build-backend = "setuptools.build_meta"
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ See [`pymatviz/rdf.py`](pymatviz/rdf.py).
| :--------------------------------: | :--------------------------------------: |
| ![element-pair-rdfs-Si16O32] | ![element-pair-rdfs-Na8Nb8O24] |

[element-pair-rdfs-Si16O32]: examples/make_assets/element-pair-rdfs-Si16O32.svg
[element-pair-rdfs-Na8Nb8O24]: examples/make_assets/element-pair-rdfs-Na8Nb8O24.svg
[element-pair-rdfs-Si16O32]: https://github.com/janosh/pymatviz/raw/main/assets/element-pair-rdfs-Si16O32.svg
[element-pair-rdfs-Na8Nb8O24]: https://github.com/janosh/pymatviz/raw/main/assets/element-pair-rdfs-Na8Nb8O24.svg

## Uncertainty

Expand Down
Loading