Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [svelte-check] Cannot find module 'svelte-multiselect' or its corresponding type declarations #236

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix [svelte-check] Cannot find module 'svelte-multiselect' or its corresponding type declarations #236

merged 1 commit into from
Jun 3, 2023

Conversation

ngyewch
Copy link
Contributor

@ngyewch ngyewch commented Jun 3, 2023 •
edited by janosh
Loading

Declare "types" (root-level) in package.json. Fixes #233.

From: #233 (comment)

The recommended fix is to update to TypeScript v5 and set "moduleResolution": "bundler". Let me know if that doesn't fix the issue or if something prevents you from upgrading.

This causes other problems for me. svelte-check can fail on some libraries when "moduleResolution" is changed.

The fix in this PR does not require the user to make changes to tsconfig.json/"compilerOptions"/"moduleResolution".

@janosh janosh changed the title Fix for [svelte-check] Cannot find module 'svelte-multiselect' or its corresponding type declarations Fix [svelte-check] Cannot find module 'svelte-multiselect' or its corresponding type declarations Jun 3, 2023
@janosh janosh added DX Developer experience types TypeScript pkg Package labels Jun 3, 2023
janosh
janosh approved these changes Jun 3, 2023
View reviewed changes
Copy link
Owner

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The one failing test is unrelated.

@janosh janosh merged commit 952101a into janosh:main Jun 3, 2023
@ngyewch ngyewch deleted the types branch June 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
DX Developer experience pkg Package types TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[svelte-check] Cannot find module 'svelte-multiselect' or its corresponding type declarations.
2 participants
@ngyewch @janosh