fix: Fix show non-grouped items as undefined (#229)

closes #66
janstuemmel · Jun 15, 2023 · 34b8a29 · 34b8a29
1 parent 69b4241
commit 34b8a29
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/common/util/groupBy.spec.ts b/src/common/util/groupBy.spec.ts
@@ -10,11 +10,20 @@ it('should group items by \'group\'', () => {
   }, {
     foo: '1',
     group: 'bar'
+  }, {
+    foo: '1',
+    group: undefined
   }];
 
   const grouped = groupBy(config, ['group']);
   expect(grouped).toMatchInlineSnapshot(`
 {
+  "": [
+    {
+      "foo": "1",
+      "group": undefined,
+    },
+  ],
   "bar": [
     {
       "foo": "1",

diff --git a/src/common/util/groupBy.ts b/src/common/util/groupBy.ts
@@ -1,6 +1,6 @@
 export const groupBy = <T>(arr: T[], keys: (keyof T)[]): { [key: string]: T[] } => {
   return arr.reduce((storage, item) => {
-    const objKey = keys.map(key => `${ item[key] }`).join(':');
+    const objKey = keys.map(key => item[key]).join(':');
     if (storage[objKey]) {
       storage[objKey].push(item);
     } else {

diff --git a/src/popup/components/SectionList.tsx b/src/popup/components/SectionList.tsx
@@ -111,7 +111,7 @@ export default <T, >({
           return item.type === 'section' ? renderSection({
             key,
             style,
-            title: item.title || 'Ungrouped',
+            title: item.title ? item.title : 'Ungrouped',
           }) : renderItem({
             key,
             style,