Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring region and role_arn #30

Closed
michellemay opened this issue Nov 11, 2022 · 5 comments · Fixed by #32
Closed

Support configuring region and role_arn #30

michellemay opened this issue Nov 11, 2022 · 5 comments · Fixed by #32
Labels
feature-request Feature Request

Comments

@michellemay
Copy link

michellemay commented Nov 11, 2022

It would be really helpful to allow adding a region to each profile

@michellemay michellemay changed the title Support changing region and role_arn Support configuring region and role_arn Nov 11, 2022
@janstuemmel
Copy link
Owner

janstuemmel commented Nov 11, 2022

Hey, role_arn is supported at master. Sorting of groups is also fixed with #27. Should come with next release...

@michellemay
Copy link
Author

Hi!

For some tasks, I need to change role and region at the same time. Our software is multi region and I do not have access to all task types in all regions. (least privileges policy)

tilfinltd/aws-extend-switch-roles supports changing region and role at the same time.. But I like your extension better because of the groups.

@janstuemmel
Copy link
Owner

janstuemmel commented Nov 12, 2022

Hi!

For some tasks, I need to change role and region at the same time. Our software is multi region and I do not have access to all task types in all regions. (least privileges policy)

tilfinltd/aws-extend-switch-roles supports changing region and role at the same time.. But I like your extension better because of the groups.

Hey. I mixed your two tickets, sry. I closed #31 now.

But i do not exactly understand what you mean by changing region and and role at the same time.
Do you mean, when you click a role, you assume the role and change the region from the actual region to the predefined (in config) one?

That i think, i could implement hat pretty quickly... and there is already a ticket for it #24

@michellemay
Copy link
Author

michellemay commented Nov 12, 2022 via email

@janstuemmel janstuemmel added the feature-request Feature Request label Nov 13, 2022
janstuemmel added a commit that referenced this issue Nov 13, 2022
@janstuemmel
Copy link
Owner

PR #32 add's region support in config. I will do a bit of manual testing and release a new version in the next week...

janstuemmel added a commit that referenced this issue Nov 14, 2022
* feat: Add region handling

closes #24
closes #30

* fix: check for valid region

* chore: update docs

* chore: update usage guide

* fix: move region check to mapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants