Skip to content

Commit

Permalink
chore: drop support for appcache-webpack-plugin as it is not compatib…
Browse files Browse the repository at this point in the history
…le to webpack 5
  • Loading branch information
jantimon committed Feb 3, 2021
1 parent 7c3146d commit a79ab17
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"devDependencies": {
"@types/loader-utils": "2.0.1",
"@types/node": "11.13.9",
"appcache-webpack-plugin": "1.4.0",
"commitizen": "4.2.1",
"css-loader": "2.1.1",
"cz-conventional-changelog": "2.1.0",
Expand Down
18 changes: 0 additions & 18 deletions spec/basic.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2067,24 +2067,6 @@ describe('HtmlWebpackPlugin', () => {
}, ['Error: HtmlWebpackPlugin: could not load file'], null, done, true);
});

it('does not add a manifest if already present', done => {
const AppCachePlugin = require('appcache-webpack-plugin');
testHtmlPlugin({
mode: 'production',
entry: path.join(__dirname, 'fixtures/index.js'),
output: {
path: OUTPUT_DIR,
filename: 'index_bundle.js'
},
plugins: [
new AppCachePlugin({ settings: ['prefer-online'] }),
new HtmlWebpackPlugin({
template: path.join(__dirname, 'fixtures/plain.html')
})
]
}, ['<html lang="en" manifest="foo.appcache">'], null, done);
});

it('works with webpack bannerplugin', done => {
testHtmlPlugin({
mode: 'production',
Expand Down

0 comments on commit a79ab17

Please sign in to comment.