Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Use a single compiler for multiple plugin instances #967

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented Jun 3, 2018

This is a wip proposal to reuse a single compiler for multiple HtmlWebpackPlugin instances.

#962
#965

@vhmth
Copy link

vhmth commented Jun 10, 2018

@jantimon what's the best way I can incorporate this into my repo for testing? Would love to test build times and get back to you with any weird discrepancies.

@jantimon
Copy link
Owner Author

cd node_modules
git clone https://github.com/jantimon/html-webpack-plugin.git
git checkout feature/cache-file-timestamps

@jantimon jantimon merged commit bbc07a3 into webpack-4 Jun 21, 2018
@vhmth
Copy link

vhmth commented Jun 21, 2018

@jantimon dopeness!

Went through and it seems like this might be the last thing to land on webpack-4? The webpack-4 branch I take it updates html-webpack-plugin@next automatically? If so, can pull from that and try this immediately.

@jantimon
Copy link
Owner Author

It's not published yet because of #972 but we might ship a new alpha soon 👍

@vhmth
Copy link

vhmth commented Jun 22, 2018

Ack ack!

@lock
Copy link

lock bot commented Jul 22, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2018
@jantimon jantimon deleted the feature/single-compiler branch February 16, 2019 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants