Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify indentation level of config in auth documentation #1651

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

JessicaJHee
Copy link
Member

Description

When trying to set the dangerouslyAllowSignInWithoutUserInCatalog config, it is confusing which indentation to place the config at. This code snippet makes it more clear.

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

@kim-tsao
Copy link
Member

/lgtm
/approve

Signed-off-by: Jessica He <jhe@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-ci openshift-ci bot removed the lgtm label Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

@gashcrumb
Copy link
Member

/override "PR Docker Build"

Copy link

openshift-ci bot commented Oct 3, 2024

@gashcrumb: Overrode contexts on behalf of gashcrumb: PR Docker Build

In response to this:

/override "PR Docker Build"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gashcrumb
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d6a652c into janus-idp:main Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants