Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update scalprum dependecies versions #925

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Jan 26, 2024

Description

This is an issue with yarn and how its dependency deduplication works. The problems are exacerbated in mono repositories.

Why was this an issue?

The scallprum test utils package has the following scalprum core version requirement:

"scalprum/core": "^0.6.*"

Ant version 0.*.* is compatible with the packages. However by locking the @scalprum/core dependency to 0.7.0 will result in the following dependency tree in the package:

yarn list --pattern @scalprum/core
yarn list v1.22.19
├─ @scalprum/core@0.6.6
└─ app@1.0.1
   └─ @scalprum/core@0.7.0

I've released versions that strictly require the latest versions of Scalprum. However, this is not an ideal solution. We might have to add yarn resolutions to ensure only actually installed packages is being used. OR switch to npm.

More information about the deduplication issues for nested dependencies can be found here: yarnpkg/yarn#3778

@Hyperkid123 Hyperkid123 requested a review from a team as a code owner January 26, 2024 09:46
Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: 3021d72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Martin Marosi <marvusm.mmi@gmail.com>
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

janus-idp bot commented Jan 26, 2024

backstage-showcase Tests on commit 961d7a7 finished with errors.
View test log

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-925!

@gashcrumb
Copy link
Member

/lgtm

@Hyperkid123
Copy link
Contributor Author

@gashcrumb any idea why is the OCP/PR Test failing? I don't have access to the IBM cloud.

@gashcrumb
Copy link
Member

Yep, lemme check, though I think at the moment it's expected that they'll fail. I tested this locally and see no problem.

@Hyperkid123 Hyperkid123 changed the title chore(deps): loosen scalprum dependecies versions chore(deps): update scalprum dependecies versions Jan 26, 2024
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the opposite of #915 #912

but with an upgrade to "@scalprum/react-test-utils": "0.1.3"

@schultzp2020 @Zaperex

@Zaperex
Copy link
Member

Zaperex commented Jan 26, 2024

I just tested it locally, and it seems to work now. Not sure why the tests e2e-tests are failing at the moment as it seems like it wasn't able to access the UI?

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told by QE that we can ignore the e2e tests for now. They don't have it fully setup.

/lgtm

Copy link

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit 1ce40dd into janus-idp:main Jan 26, 2024
5 of 8 checks passed
@Hyperkid123 Hyperkid123 deleted the align-scalprum branch January 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants