Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Auto-push bundle manifests changes to PR branch if needed #195

Merged
merged 13 commits into from
Mar 6, 2024
Merged

Auto-push bundle manifests changes to PR branch if needed #195

merged 13 commits into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. Make PR checks fail if bundle or manifests are not up-to-date 

    This is so that PR authors do not forget to regenerate those manifests.
    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7b303cb View commit details
    Browse the repository at this point in the history

  2. Update developer guide

    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    302a4a7 View commit details
    Browse the repository at this point in the history

  3. Save diff as patch file, so it can be downloaded and applied with Git

    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b9eb0fa View commit details
    Browse the repository at this point in the history

  4. Fix step names in PR Validation job

    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1bb17de View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Jianrong Zhang <jianrzha@redhat.com>
    @rm3l @jianrongzhang89
    rm3l and jianrongzhang89 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a2b4add View commit details
    Browse the repository at this point in the history

  6. Do not error out if bundle manifests are outdated 

    Display warnings instead.
Also comment on the PR so that authors/reviewers are aware of that fact.

Co-authored-by: Gennady Azarenkov <gazarenkov@gmail.com>
    @rm3l @gazarenkov
    rm3l and gazarenkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    676e5ae View commit details
    Browse the repository at this point in the history

  7. Update .github/workflows/pr.yaml 

    Co-authored-by: Nick Boldt <nboldt@redhat.com>
    @rm3l @nickboldt
    rm3l and nickboldt committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7675f03 View commit details
    Browse the repository at this point in the history

  8. Revert "Do not error out if bundle manifests are outdated" 

    This reverts commit ab2c12a.
    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    32f5b30 View commit details
    Browse the repository at this point in the history

  9. Auto-push any changes to the bundle manifests 

    This will alleviate the burden on contributors and maintainers.
    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    120cb77 View commit details
    Browse the repository at this point in the history

  10. Run bundle diff checker in separate workflow triggered on 'pull_reque… 

    …st_target' events

This is required to be able to write to fork PR branches

Similar to what we do already with the pull_request_target workflows, we also require manual authorization for unknown external forks, to prevent PWN requests
    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8d31c5a View commit details
    Browse the repository at this point in the history

  11. Update PR template to think about eventually updating the rhdh-operat… 

    …or.csv.yaml file
    @rm3l
    rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    225382e View commit details
    Browse the repository at this point in the history

  12. Update .github/workflows/pr-bundle-diff-checks.yaml

    @nickboldt @rm3l
    nickboldt authored and rm3l committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ce17e45 View commit details
    Browse the repository at this point in the history

  13. Update docs/developer.md 

    Co-authored-by: Gennady Azarenkov <gazarenkov@redhat.com>
    @rm3l
    rm3l and Gennady Azarenkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d94f209 View commit details
    Browse the repository at this point in the history